Skip to content

Fix typo in reduce_util.h from my #9144 #12720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2025
Merged

Fix typo in reduce_util.h from my #9144 #12720

merged 3 commits into from
Aug 11, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 22, 2025 •
edited
Loading

No description provided.

@swolchok
Update
d2e93ff 
[ghstack-poisoned]
@swolchok swolchok requested a review from manuelcandales as a code owner July 22, 2025 17:48
@swolchok
Copy link
Contributor Author

swolchok commented Jul 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12720

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 36 Pending, 1 Unrelated Failure

As of commit f596553 with merge base 6c74651 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 22, 2025
@swolchok
Fix typo in reduce_util.h from my #9144
d55575d 
ghstack-source-id: 8276173
ghstack-comment-id: 3104082224
Pull-Request: #12720
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok
rebase
ca1314e 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 24, 2025
@swolchok
Fix typo in reduce_util.h from my #9144
223eb8d 
ghstack-source-id: acb23c9
ghstack-comment-id: 3104082224
Pull-Request: #12720
@swolchok
rebase
f596553 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Aug 11, 2025
@swolchok
Fix typo in reduce_util.h from my #9144
2abf83f 
ghstack-source-id: 26d7e03
ghstack-comment-id: 3104082224
Pull-Request: #12720
@swolchok swolchok merged commit a84b3c9 into main Aug 11, 2025
99 of 101 checks passed
@swolchok swolchok deleted the gh/swolchok/526/head branch August 11, 2025 23:02
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@swolchok @agrima1304
Fix typo in reduce_util.h from my pytorch#9144 (pytorch#12720)
89b714b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @GregoryComer @facebook-github-bot